From: Eric Sunshine Date: Wed, 29 Apr 2020 22:48:51 GMT Subject: Re: [PATCH 2/5] shallow: extract a header file for shallow-related functions Message-ID: In-Reply-To: <0b93abe072aa35ab96ba3b97118caa8ffe8e439d.1588199705.git.me@ttaylorr.com> On Wed, Apr 29, 2020 at 6:39 PM Taylor Blau wrote: > There are many functions in commit.h that are more related to shallow > repositories than they are to any sort of generic commit machinery. > Likely this began when there were only a few shallow-related functions, > and commit.h seemed a reasonable enough place to put them. > > But, now there are a good number of shallow-related functions, and > placing them all in 'commit.h' doesn't make sense. > > This patch extracts a 'shallow.h', which takes all of the headers from Did you mean s/headers/declarations/ ? > 'commit.h' for functions which already exist in 'shallow.c'. We will > bring the remaining shallow-related functions defined in 'commit.c' in a > subsequent patch. > > For now, move only the ones that already are implemented in 'shallow.c', > and update the necessary includes. > > Signed-off-by: Taylor Blau