git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/5] commit: move 'unregister_shallow' to 'shallow.h'

From
Taylor Blau <me@ttaylorr.com>
Date
Apr 29, 2020, 22:39 UTC
Message-ID
<65ecfeaba56807926fbe532f94921c98298e50d5.1588199705.git.me@ttaylorr.com>
In-Reply-To
<cover.1588199705.git.me@ttaylorr.com>

In the last commit, we introduced a header for the functions defined in 'shallow.c'. There is one remaining shallow-related function in commit.c which should be moved, too. This patch moves that function.

Signed-off-by: Taylor Blau <me@ttaylorr.com>
---
 commit.c  | 13 -------------
 shallow.c | 13 +++++++++++++
 shallow.h |  1 +
 3 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/commit.c b/commit.c
index eebfbeb45d..87686a7055 100644
--- a/commit.c
+++ b/commit.c
@@ -246,19 +246,6 @@ int for_each_commit_graft(each_commit_graft_fn fn, void *cb_data)
 	return ret;
 }
 
-int unregister_shallow(const struct object_id *oid)
-{
-	int pos = commit_graft_pos(the_repository, oid->hash);
-	if (pos < 0)
-		return -1;
-	if (pos + 1 < the_repository->parsed_objects->grafts_nr)
-		MOVE_ARRAY(the_repository->parsed_objects->grafts + pos,
-			   the_repository->parsed_objects->grafts + pos + 1,
-			   the_repository->parsed_objects->grafts_nr - pos - 1);
-	the_repository->parsed_objects->grafts_nr--;
-	return 0;
-}
-
 struct commit_buffer {
 	void *buffer;
 	unsigned long size;
diff --git a/shallow.c b/shallow.c
index d0191c7609..76e00893fe 100644
--- a/shallow.c
+++ b/shallow.c
@@ -39,6 +39,19 @@ int register_shallow(struct repository *r, const struct object_id *oid)
 	return register_commit_graft(r, graft, 0);
 }
 
+int unregister_shallow(const struct object_id *oid)
+{
+	int pos = commit_graft_pos(the_repository, oid->hash);
+	if (pos < 0)
+		return -1;
+	if (pos + 1 < the_repository->parsed_objects->grafts_nr)
+		MOVE_ARRAY(the_repository->parsed_objects->grafts + pos,
+			   the_repository->parsed_objects->grafts + pos + 1,
+			   the_repository->parsed_objects->grafts_nr - pos - 1);
+	the_repository->parsed_objects->grafts_nr--;
+	return 0;
+}
+
 int is_repository_shallow(struct repository *r)
 {
 	FILE *fp;
diff --git a/shallow.h b/shallow.h
index 14dd748625..b50a85ed7e 100644
--- a/shallow.h
+++ b/shallow.h
@@ -8,6 +8,7 @@
 
 void set_alternate_shallow_file(struct repository *r, const char *path, int override);
 int register_shallow(struct repository *r, const struct object_id *oid);
+int unregister_shallow(const struct object_id *oid);
 int is_repository_shallow(struct repository *r);
 int commit_shallow_file(struct repository *r, struct lock_file *lk);
 void rollback_shallow_file(struct repository *r, struct lock_file *lk);
-- 
2.26.0.113.ge9739cdccc
Previous: Jonathan NiederNext: Jonathan Nieder
Message 11 of 22 in “shallow: extract a header file”
  1. 0/5 shallow: extract a header fileTaylor Blau, Apr 29, 2020
  2. 1/5 commit: make 'commit_graft_pos' non-staticTaylor Blau, Apr 29, 2020
  3. Jonathan NiederApr 30, 2020
  4. Taylor BlauApr 30, 2020
  5. 2/5 shallow: extract a header file for shallow-related functionsTaylor Blau, Apr 29, 2020
  6. Eric SunshineApr 29, 2020
  7. Jonathan TanApr 30, 2020
  8. Taylor BlauApr 30, 2020
  9. Jonathan TanApr 30, 2020
  10. Jonathan NiederApr 30, 2020
  11. 3/5 commit: move 'unregister_shallow' to 'shallow.h'Taylor Blau, Apr 29, 2020
  12. Jonathan NiederApr 30, 2020
  13. Taylor BlauApr 30, 2020
  14. 4/5 shallow.h: document '{commit,rollback}_shallow_file'Taylor Blau, Apr 29, 2020
  15. Eric SunshineApr 29, 2020
  16. 5/5 shallow: use struct 'shallow_lock' for additional safetyTaylor Blau, Apr 29, 2020
  17. Eric SunshineApr 29, 2020
  18. Taylor BlauApr 29, 2020
  19. Jonathan TanApr 30, 2020
  20. Jonathan NiederApr 30, 2020
  21. Eric SunshineApr 30, 2020
  22. Taylor BlauApr 30, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.