git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] doc: Don't echo sed command for manpage-base-url.xsl

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Aug 28, 2018, 21:25 UTC
Message-ID
<CAPig+cRnPziVKe0pxqb+QTMTZCDvWvLfQUFLU53aYuOW4Mm52A@mail.gmail.com>
In-Reply-To
<20180828212104.2515-1-timschumi@gmx.de>
On Tue, Aug 28, 2018 at 5:21 PM Tim Schumacher <timschumi@gmx.de> wrote:
Show 7 quoted lines
> Previously, the sed command for generating manpage-base-url.xsl
> was printed to the console when being run.
>
> For the purpose of silencing it, define a $(QUIET) variable which
> contains an '@' if verbose mode isn't enabled and which is empty
> otherwise. This just silences the command invocation without doing
> anything else.

One thing that is missing from this commit message is the explanation of _why_ this is desirable. And, why only this command? Without understanding the underlying reason(s), it's hard to judge the value of this change.

Thanks.
Previous: Tim SchumacherNext: Junio C Hamano
Message 2 of 9 in “doc: Don't echo sed command for manpage-base-url.xsl”
  1. doc: Don't echo sed command for manpage-base-url.xslTim Schumacher, Aug 28, 2018
  2. Eric SunshineAug 28, 2018
  3. Junio C HamanoAug 28, 2018
  4. doc: Don't echo sed command for manpage-base-url.xslTim Schumacher, Aug 29, 2018
  5. doc: Don't echo sed command for manpage-base-url.xslTim Schumacher, Aug 29, 2018
  6. Jonathan NiederAug 29, 2018
  7. Tim SchumacherAug 29, 2018
  8. Junio C HamanoAug 29, 2018
  9. Jonathan NiederAug 29, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.