Re: [PATCH v3] doc: Don't echo sed command for manpage-base-url.xsl

From: Tim Schumacher <timschumi@gmx.de>
Date: Aug 29, 2018, 17:42 UTC
Message-ID: <c38b994b-b77d-fe03-42f9-9e22ac92e98d@gmx.de>
In-Reply-To: <20180829165540.GB170940@aiede.svl.corp.google.com>

On 29.08.18 18:55, Jonathan Nieder wrote:

Show 10 quoted lines

> Tim Schumacher wrote:
> 
>> Subject: doc: Don't echo sed command for manpage-base-url.xsl
> 
> Cribbing from my review of v2: a description like
> 
> 	Documentation/Makefile: make manpage-base-url.xsl generation quieter
> 
> would make it more obvious what this does when viewed in "git log
> --oneline".

imho, the "Documentation/Makefile" is a bit too long (about 1/3 of the first line). Would it be advisable to keep the previous prefix of "doc" (which would shorten down the line from 68 characters down to 49) and to use only the second part of your proposed first line? Depending on the response I would address this in v4 of this patch.

Show 18 quoted lines

> 
>> Previously, the sed command for generating manpage-base-url.xsl
>> was printed to the console when being run.
>>
>> Make the console output for this rule similiar to all the
>> other rules by printing a short status message instead of
>> the whole command.
>>
>> Signed-off-by: Tim Schumacher <timschumi@gmx.de>
>> ---
>>   Documentation/Makefile | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Oh!  Ignore my reply to v2; looks like you anticipated what I was
> going to suggest already.  For next time, if you include a note about
> what changed between versions after the --- delimiter, that can help
> save some time.
>

The change to QUIET_GEN was proposed by Junio, but that E-Mail wasn't CC'ed to the mailing list, probably due to him typing the response on a phone.

I originally included a note about the change as well, but I forgot to copy it over to the new patch after I generated a second version of v3.

Show 6 quoted lines

> With or without the suggested commit message tweak,
> 
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> 
> Thank you.
>

Thanks for the review!