Re: [PATCH] doc: Don't echo sed command for manpage-base-url.xsl
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 28, 2018, 21:35 UTC
- Message-ID
- <xmqqsh2ydvj4.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180828212104.2515-1-timschumi@gmx.de>
Tim Schumacher <timschumi@gmx.de> writes:
Show 10 quoted lines
> Previously, the sed command for generating manpage-base-url.xsl > was printed to the console when being run. > > For the purpose of silencing it, define a $(QUIET) variable which > contains an '@' if verbose mode isn't enabled and which is empty > otherwise. This just silences the command invocation without doing > anything else. > > Signed-off-by: Tim Schumacher <timschumi@gmx.de> > ---
I am not sure if this is a good change. All these QUIET_$TOOL hide details of running the $TOOL to produce the final output of the step, but they still do report what they are creating via which $TOOL.
Shouldn't the step to create manpage-base-url.xsl be the same? The detail of creating it (i.e. token @@MAN_BASE_URL@@ is replaced with the actual value) may want to be squelched, but shouldn't we still be reporting that we are creating manpage-base-url.xsl file?
Show 24 quoted lines
> Documentation/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/Makefile b/Documentation/Makefile > index a42dcfc74..45454e9b5 100644 > --- a/Documentation/Makefile > +++ b/Documentation/Makefile > @@ -217,6 +217,7 @@ endif > > ifneq ($(findstring $(MAKEFLAGS),s),s) > ifndef V > + QUIET = @ > QUIET_ASCIIDOC = @echo ' ' ASCIIDOC $@; > QUIET_XMLTO = @echo ' ' XMLTO $@; > QUIET_DB2TEXI = @echo ' ' DB2TEXI $@; > @@ -344,7 +345,7 @@ $(OBSOLETE_HTML): %.html : %.txto asciidoc.conf > mv $@+ $@ > > manpage-base-url.xsl: manpage-base-url.xsl.in > - sed "s|@@MAN_BASE_URL@@|$(MAN_BASE_URL)|" $< > $@ > + $(QUIET)sed "s|@@MAN_BASE_URL@@|$(MAN_BASE_URL)|" $< > $@ > > %.1 %.5 %.7 : %.xml manpage-base-url.xsl > $(QUIET_XMLTO)$(RM) $@ && \