From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 28 Aug 2018 21:25:42 GMT
Subject: Re: [PATCH] doc: Don't echo sed command for manpage-base-url.xsl
Message-ID: <CAPig+cRnPziVKe0pxqb+QTMTZCDvWvLfQUFLU53aYuOW4Mm52A@mail.gmail.com>
In-Reply-To: <20180828212104.2515-1-timschumi@gmx.de>

On Tue, Aug 28, 2018 at 5:21 PM Tim Schumacher <timschumi@gmx.de> wrote:
> Previously, the sed command for generating manpage-base-url.xsl
> was printed to the console when being run.
>
> For the purpose of silencing it, define a $(QUIET) variable which
> contains an '@' if verbose mode isn't enabled and which is empty
> otherwise. This just silences the command invocation without doing
> anything else.

One thing that is missing from this commit message is the explanation
of _why_ this is desirable. And, why only this command? Without
understanding the underlying reason(s), it's hard to judge the value
of this change.

Thanks.