Re: [PATCH v3] doc: Don't echo sed command for manpage-base-url.xsl

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 29, 2018, 16:55 UTC
Message-ID: <20180829165540.GB170940@aiede.svl.corp.google.com>
In-Reply-To: <20180829154720.20297-1-timschumi@gmx.de>

Tim Schumacher wrote:

> Subject: doc: Don't echo sed command for manpage-base-url.xsl

Cribbing from my review of v2: a description like

	Documentation/Makefile: make manpage-base-url.xsl generation quieter

would make it more obvious what this does when viewed in "git log --oneline".

Show 11 quoted lines

> Previously, the sed command for generating manpage-base-url.xsl
> was printed to the console when being run.
>
> Make the console output for this rule similiar to all the
> other rules by printing a short status message instead of
> the whole command.
>
> Signed-off-by: Tim Schumacher <timschumi@gmx.de>
> ---
>  Documentation/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Oh! Ignore my reply to v2; looks like you anticipated what I was going to suggest already. For next time, if you include a note about what changed between versions after the --- delimiter, that can help save some time.

With or without the suggested commit message tweak,

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thank you.