git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] doc: Don't echo sed command for manpage-base-url.xsl

From
Tim Schumacher <timschumi@gmx.de>
Date
Aug 29, 2018, 13:43 UTC
Message-ID
<20180829134334.14619-1-timschumi@gmx.de>
In-Reply-To
<20180828212104.2515-1-timschumi@gmx.de>

Previously, the sed command for generating manpage-base-url.xsl was printed to the console when being run.

Make the console output for this rule similiar to all the other rules by printing a short status message instead of the whole command.

Signed-off-by: Tim Schumacher <timschumi@gmx.de>
---

To Junio C Hamano: The rule does now print "SED manpage-base-url.xsl" to the console, which is similiar to other QUIET_$TOOL rules.

To Eric Sunshine: I reworded the commit message to focus more on _why_ the patch is relevant.

---
 Documentation/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/Makefile b/Documentation/Makefile
index a42dcfc74..cbf33c5a7 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -225,6 +225,7 @@ ifndef V
 	QUIET_XSLTPROC	= @echo '   ' XSLTPROC $@;
 	QUIET_GEN	= @echo '   ' GEN $@;
 	QUIET_LINT	= @echo '   ' LINT $@;
+	QUIET_SED	= @echo '   ' SED $@;
 	QUIET_STDERR	= 2> /dev/null
 	QUIET_SUBDIR0	= +@subdir=
 	QUIET_SUBDIR1	= ;$(NO_SUBDIR) echo '   ' SUBDIR $$subdir; \
@@ -344,7 +345,7 @@ $(OBSOLETE_HTML): %.html : %.txto asciidoc.conf
 	mv $@+ $@
 
 manpage-base-url.xsl: manpage-base-url.xsl.in
-	sed "s|@@MAN_BASE_URL@@|$(MAN_BASE_URL)|" $< > $@
+	$(QUIET_SED)sed "s|@@MAN_BASE_URL@@|$(MAN_BASE_URL)|" $< > $@
 
 %.1 %.5 %.7 : %.xml manpage-base-url.xsl
 	$(QUIET_XMLTO)$(RM) $@ && \
-- 
2.19.0.rc1.1.g093671f86
Previous: Junio C HamanoNext: Tim Schumacher
Message 4 of 9 in “doc: Don't echo sed command for manpage-base-url.xsl”
  1. doc: Don't echo sed command for manpage-base-url.xslTim Schumacher, Aug 28, 2018
  2. Eric SunshineAug 28, 2018
  3. Junio C HamanoAug 28, 2018
  4. doc: Don't echo sed command for manpage-base-url.xslTim Schumacher, Aug 29, 2018
  5. doc: Don't echo sed command for manpage-base-url.xslTim Schumacher, Aug 29, 2018
  6. Jonathan NiederAug 29, 2018
  7. Tim SchumacherAug 29, 2018
  8. Junio C HamanoAug 29, 2018
  9. Jonathan NiederAug 29, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.