Re: [PATCH 7/7] remote-mediawiki: show progress while fetching namespaces

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Nov 1, 2017, 20:01 UTC
Message-ID: <CAPig+cR9h-DS3NLzHVdnad420HtN3Afg+1BHBZBzG1EG0=U45g@mail.gmail.com>
In-Reply-To: <20171030025142.19421-8-anarcat@debian.org>

On Sun, Oct 29, 2017 at 10:51 PM, Antoine Beaupré <anarcat@debian.org> wrote:

Show 6 quoted lines

> Without this, the fetch process seems hanged while we fetch page
> listings across the namespaces. Obviously, it should be possible to
> silence this with -q, but that's an issue already present everywhere
> in the code and should be fixed separately:
>
> https://github.com/Git-Mediawiki/Git-Mediawiki/issues/30

Unlike the previous round, this commit message makes it clear that this new printed message is indeed intentional. Thanks.

Show 19 quoted lines

> Signed-off-by: Antoine Beaupré <anarcat@debian.org>
> ---
>  contrib/mw-to-git/git-remote-mediawiki.perl | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl
> index 5199af6f6..61e6dd798 100755
> --- a/contrib/mw-to-git/git-remote-mediawiki.perl
> +++ b/contrib/mw-to-git/git-remote-mediawiki.perl
> @@ -278,6 +278,7 @@ sub get_mw_tracked_namespaces {
>              aplimit => 'max' } )
>              || die $mediawiki->{error}->{code} . ': '
>                  . $mediawiki->{error}->{details} . "\n";
> +        print {*STDERR} "$#{$mw_pages} found in namespace $local_namespace ($namespace_id)\n";
>          foreach my $page (@{$mw_pages}) {
>              $pages->{$page->{title}} = $page;
>          }
> --
> 2.11.0