Re: [PATCH v4 2/7] remote-mediawiki: allow fetching namespaces with spaces

From: Thomas Adam <thomas@xteddy.org>
Date: Nov 7, 2017, 07:08 UTC
Message-ID: <20171107070808.q7zz4i73mkffomcb@laptop.local>
In-Reply-To: <20171106211953.27910-3-anarcat@debian.org>

On Mon, Nov 06, 2017 at 04:19:48PM -0500, Antoine Beaupré wrote:

Show 22 quoted lines

> From: Ingo Ruhnke <grumbel@gmail.com>
> 
> we still want to use spaces as separators in the config, but we should
> allow the user to specify namespaces with spaces, so we use underscore
> for this.
> 
> Reviewed-by: Antoine Beaupré <anarcat@debian.org>
> Signed-off-by: Antoine Beaupré <anarcat@debian.org>
> ---
>  contrib/mw-to-git/git-remote-mediawiki.perl | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl
> index 5ffb57595..a1d783789 100755
> --- a/contrib/mw-to-git/git-remote-mediawiki.perl
> +++ b/contrib/mw-to-git/git-remote-mediawiki.perl
> @@ -65,6 +65,7 @@ chomp(@tracked_categories);
>  
>  # Just like @tracked_categories, but for MediaWiki namespaces.
>  my @tracked_namespaces = split(/[ \n]/, run_git("config --get-all remote.${remotename}.namespaces"));
> +for (@tracked_namespaces) { s/_/ /g; }
>  chomp(@tracked_namespaces);

Depending on the number if namespaces returned, it might be easier to convert this to the following:

    my @tracked_namespaces = map {
    	chomp; s/_/ /g; $_;
    } split(/[ \n]/, run_git("config --get-all remote.${remotename}.namespaces"));

This would, once again, avoid creating @tracked_namespaces, and iterating over it.

Note that this isn't about trying to 'golf' this; it's a performance consideration.

Kindly, Thomas Adam