Re: [PATCH 1/4] remote-mediawiki: add namespace support

From: Antoine Beaupré <anarcat@debian.org>
Date: Oct 30, 2017, 02:14 UTC
Message-ID: <871sll8jqv.fsf@curie.anarc.at>
In-Reply-To: <6ed0d8d4-243a-7afc-bd37-a6f71004e195@ki-ai.org>

On 2017-10-29 23:08:00, Kevin wrote:

> So I shared the patch some time ago (~2 years). Surprisingly its just
> now getting attention. I guess some renewed interest in using mediawiki
> with git.

I think what's happening is that someone (ie. me :p) figured it was about frigging time to actually send those patches to the git mailing list. ;) And I'm glad we're seeing such good reviews, so thanks Eric for that...

> Myself, however, am no longer using mediawiki. Nor am I
> completely clear on what the reasons were for using some variable or
> another a couple of years ago. So... the best of luck, sorry I couldn't
> be more helpful.

That's too bad, but thanks for the feedback anyways. :)

Frankly, I'm tempted to just completely remove the get_mw_namespace_id_for_page hunk - it's completely unrelated to the rest of the patch.

Could that be a bugfix for a separate issue that crept up in your patchset? For example this?

https://github.com/Git-Mediawiki/Git-Mediawiki/issues/43

A.

-- 
That's one of the remarkable things about life: it's never so bad that
it can't get worse.
                        - Calvin