Re: [PATCH v3 4/7] remote-mediawiki: skip virtual namespaces

From: Antoine Beaupré <anarcat@debian.org>
Date: Nov 2, 2017, 22:54 UTC
Message-ID: <87r2tg47hh.fsf@curie.anarc.at>
In-Reply-To: <CAPig+cR0jG65LbopxqPpidaaNUSTRq9tboZpv0RPWyWUkSEGUw@mail.gmail.com>

On 2017-11-02 18:43:00, Eric Sunshine wrote:

Show 17 quoted lines

> On Thu, Nov 2, 2017 at 5:25 PM, Antoine Beaupré <anarcat@debian.org> wrote:
>> Virtual namespaces do not correspond to pages in the database and are
>> automatically generated by MediaWiki. It makes little sense,
>> therefore, to fetch pages from those namespaces and the MW API doesn't
>> support listing those pages.
>>
>> According to the documentation, those virtual namespaces are currently
>> "Special" (-1) and "Media" (-2) but we treat all negative namespaces
>> as "virtual" as a future-proofing mechanism.
>>
>> Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
>
> It probably would be best to omit this Reviewed-by: since it was not
> provided explicitly. More importantly, I'm neither a user of nor
> familiar with MediaWiki or its API, so a Reviewed-by: from me has
> little or no value. Probably best would be for someone such as
> Matthieu to give his Reviewed-by: if he so desires.

Alright, I was wondering what the process was for those. I didn't want to leave your contributions by the wayside...

I'll wait a little while longer for more feedback and then resend without those. unless...

@junio: my github repo has the branch without those Reviewed-by tags, iirc. so if you can to merge from there, that will keep me from sending yet another pile of patches for such a trivial change...

a.

-- 
Semantics is the gravity of abstraction.