Re: [PATCH 4/4] remote-mediawiki: allow using (Main) as a namespace and skip special namespaces
On 2017-10-29 23:52:16, Eric Sunshine wrote:
Show 20 quoted lines
> On Sun, Oct 29, 2017 at 10:43 PM, Antoine Beaupré <anarcat@debian.org> wrote:
>> On 2017-10-29 15:49:28, Eric Sunshine wrote:
>>> This may be problematic since get_mw_namespace_id() may return undef
>>> rather than a number, in which case Perl will complain.
>>
>> Actually, get_mw_namespace_id() doesn't seem like it can return undef -
>> did you mistake it with get_mw_namespace_id_for_page()?
>
> Hmm, no. What I see in the function is this:
>
> my $id;
> ...
> if ($ns->{is_namespace}) {
> $id = $ns->{id};
> }
> ...
> return $id;
>
> So, $id starts undefined and is assigned only conditionally before
> being returned, but perhaps I'm missing some subtlety.Ah yes, you're probably right there.
--
During the initial stage of the struggle, the oppressed, instead of
striving for liberation, tend themselves to become oppressors The very
structure of their thought has been conditioned by the contradictions of
the concrete, existential situation by which they were shaped. Their
ideal is to be men; but for them, to be men is to be oppressors. This is
their model of humanity.
- Paulo Freire, Pedagogy of the OppressedAntoine Beaupré <anarcat@debian.org>