git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 19/22] sequencer.c: mark more strings for translation

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jun 3, 2018, 18:27 UTC
Message-ID
<CAPig+cQUC64j6RUZG3LWP+dm9HrvCBi+ayO0w5pmCkBU=vO_1A@mail.gmail.com>
In-Reply-To
<CACsJy8BXHDK8s-tSVkMG8sSu+DXwKxSkGqN+7ME8Lm9CjOx9GQ@mail.gmail.com>
On Sun, Jun 3, 2018 at 11:14 AM, Duy Nguyen <pclouds@gmail.com> wrote:
Show 11 quoted lines
> On Sun, Jun 3, 2018 at 10:16 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> On Sat, Jun 2, 2018 at 12:32 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>>> -               fprintf(stderr, "Could not apply %s... %.*s\n",
>>> +               fprintf_ln(stderr, _("Could not apply %s... %.*s"),
>>
>> Did you want to downcase "Could" for consistency with other error
>> messages, or was this left as-is intentionally?
>
> I'm not sure. Others start with a prefix (like "error:",
> "warning:"....). This is a bit different and makes me hesitate.

Yep, I realized after hitting Send that this wasn't an error/warning message so probably shouldn't be changed.

Previous: Duy NguyenNext: Nguyễn Thái Ngọc Duy
Message 35 of 64 in “Mark more strings for translation”
  1. 00/22 Mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  2. 01/22 archive-tar.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  3. 02/22 archive-zip.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  4. Duy NguyenJun 2, 2018
  5. brian m. carlsonJun 3, 2018
  6. 03/22 builtin/config.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  7. Eric SunshineJun 3, 2018
  8. Duy NguyenJun 3, 2018
  9. 05/22 builtin/pack-objects.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  10. 04/22 builtin/grep.c: mark strings for translation and no full stopsNguyễn Thái Ngọc Duy, Jun 2, 2018
  11. 09/22 connect.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  12. Eric SunshineJun 3, 2018
  13. 08/22 config.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  14. Eric SunshineJun 3, 2018
  15. 07/22 commit-graph.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  16. 14/22 object.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  17. 13/22 exec-cmd.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  18. 12/22 environment.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  19. 11/22 dir.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  20. Eric SunshineJun 3, 2018
  21. 10/22 convert.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  22. Eric SunshineJun 3, 2018
  23. 06/22 builtin/replace.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  24. Eric SunshineJun 3, 2018
  25. 22/22 transport-helper.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  26. Eric SunshineJun 3, 2018
  27. 21/22 transport.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  28. Eric SunshineJun 3, 2018
  29. Duy NguyenJun 3, 2018
  30. 20/22 sha1-file.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  31. Eric SunshineJun 3, 2018
  32. 19/22 sequencer.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  33. Eric SunshineJun 3, 2018
  34. Duy NguyenJun 3, 2018
  35. Eric SunshineJun 3, 2018
  36. 18/22 replace-object.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  37. 17/22 refspec.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  38. 16/22 refs.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  39. Eric SunshineJun 3, 2018
  40. 15/22 pkt-line.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 2, 2018
  41. 00/23 Mark strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  42. 01/23 Update messages in preparation for i18nNguyễn Thái Ngọc Duy, Jun 3, 2018
  43. 04/23 builtin/config.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  44. 11/23 convert.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  45. 14/23 exec-cmd.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  46. 12/23 dir.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  47. 20/23 sequencer.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  48. 21/23 sha1-file.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  49. 18/23 refspec.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  50. 22/23 transport.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  51. 19/23 replace-object.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  52. 23/23 transport-helper.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  53. 13/23 environment.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  54. 17/23 refs.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  55. 03/23 archive-zip.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  56. 15/23 object.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  57. 10/23 connect.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  58. 16/23 pkt-line.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  59. 02/23 archive-tar.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  60. 09/23 config.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  61. 05/23 builtin/grep.c: mark strings for translation and no full stopsNguyễn Thái Ngọc Duy, Jun 3, 2018
  62. 07/23 builtin/replace.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  63. 08/23 commit-graph.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018
  64. 06/23 builtin/pack-objects.c: mark more strings for translationNguyễn Thái Ngọc Duy, Jun 3, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.