Re: [PATCH 02/22] archive-zip.c: mark more strings for translation

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Jun 3, 2018, 18:27 UTC
Message-ID: <20180603182724.GA288937@genre.crustytoothpaste.net>
In-Reply-To: <CACsJy8DZC1xd5O=Qf=HEQeDQ0xpwExnnLvgqemNE77mVwQckeg@mail.gmail.com>

On Sat, Jun 02, 2018 at 08:17:47AM +0200, Duy Nguyen wrote:

Show 9 quoted lines

> On Sat, Jun 2, 2018 at 6:32 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> >         if (pathlen > 0xffff) {
> > -               return error("path too long (%d chars, SHA1: %s): %s",
> > +               return error(_("path too long (%d chars, SHA1: %s): %s"),
> >                                 (int)pathlen, oid_to_hex(oid), path);
> 
> Off topic. Brian, do we have a common term to use here (i.e. in user
> facing messages) instead of "SHA1" after we move away from it? Is it
> still "object name", or "hash" or some other fancy term?

You could say "object ID" or "object" here. It should be clear from context what that means. I tend to use "hash" for things which are not necessarily object IDs (e.g. pack hash).

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204