Re: [PATCH 19/22] sequencer.c: mark more strings for translation
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Jun 3, 2018, 15:14 UTC
- Message-ID
- <CACsJy8BXHDK8s-tSVkMG8sSu+DXwKxSkGqN+7ME8Lm9CjOx9GQ@mail.gmail.com>
- In-Reply-To
- <CAPig+cRCJbZxaO6vmt+8D7aOLZDGrDVDMB97zfRAfwmtRPP_Zg@mail.gmail.com>
On Sun, Jun 3, 2018 at 10:16 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 27 quoted lines
> On Sat, Jun 2, 2018 at 12:32 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>> ---
>> diff --git a/sequencer.c b/sequencer.c
>> @@ -2597,15 +2597,17 @@ static int error_with_patch(struct commit *commit,
>> - fprintf(stderr, "You can amend the commit now, with\n"
>> - "\n"
>> - " git commit --amend %s\n"
>> - "\n"
>> - "Once you are satisfied with your changes, run\n"
>> - "\n"
>> - " git rebase --continue\n", gpg_sign_opt_quoted(opts));
>> + fprintf(stderr,
>> + _("You can amend the commit now, with\n"
>> + "\n"
>> + " git commit --amend %s\n"
>> + "\n"
>> + "Once you are satisfied with your changes, run\n"
>> + "\n"
>> + " git rebase --continue\n"),
>> + gpg_sign_opt_quoted(opts));
>> } else if (exit_code)
>> - fprintf(stderr, "Could not apply %s... %.*s\n",
>> + fprintf_ln(stderr, _("Could not apply %s... %.*s"),
>
> Did you want to downcase "Could" for consistency with other error
> messages, or was this left as-is intentionally?I'm not sure. Others start with a prefix (like "error:", "warning:"....). This is a bit different and makes me hesitate.
-- Duy