Re: [PATCH 03/22] builtin/config.c: mark more strings for translation

From: Duy Nguyen <pclouds@gmail.com>
Date: Jun 3, 2018, 15:00 UTC
Message-ID: <CACsJy8BorDWr-MyfDGrDQ+dWP5OvtFjXqEW-m=TxOFJrZ+62tg@mail.gmail.com>
In-Reply-To: <CAPig+cQ8p=V7nCJDgJvD2f7pAjykBjN_4BnjY0XHPugE3yL_Tg@mail.gmail.com>

On Sun, Jun 3, 2018 at 11:01 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 16 quoted lines

> On Sat, Jun 2, 2018 at 12:32 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>> There are also some minor adjustments in the strings.
>>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>> ---
>> diff --git a/builtin/config.c b/builtin/config.c
>> @@ -746,7 +746,7 @@ int cmd_config(int argc, const char **argv, const char *prefix)
>>                 if (ret == CONFIG_NOTHING_SET)
>>                         error(_("cannot overwrite multiple values with a single value\n"
>> -                       "       Use a regexp, --add or --replace-all to change %s."), argv[0]);
>> +                       "       Use a regexp, --add or --replace-all to change %s"), argv[0]);
>
> Perhaps?
>
>     cannot overwrite multiple values with a single value;
>     use a regexp, --add or --replace-all to change %s

I'll probably leave these multi sentence errors alone. There's some work going on about these multiple sentence messages. We can come back after that series settles.

Show 17 quoted lines

>> @@ -819,7 +819,7 @@ int cmd_config(int argc, const char **argv, const char *prefix)
>>                 if (ret == 0)
>> -                       die("No such section!");
>> +                       die(_("no such section!"));
>> @@ -830,7 +830,7 @@ int cmd_config(int argc, const char **argv, const char *prefix)
>>                 if (ret == 0)
>> -                       die("No such section!");
>> +                       die(_("no such section!"));
>
> In other patches, you dropped the trailing "!"; perhaps do so for
> these two also?
>
> Maybe even:
>
>     die(_("no such section: %s", whatever);
>
> Though, that may be out of scope of this patch series.

Might as well do it while I'm at it. I'll do it in a separate patch though and try to keep these i18n patches about _() only.

-- 
Duy