Re: [PATCH 06/22] builtin/replace.c: mark more strings for translation

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 3, 2018, 08:41 UTC
Message-ID: <CAPig+cSnPhi1e4QZ=ZJBC2aS0n7gfwo=q-bR22W_dj_QjJbLZw@mail.gmail.com>
In-Reply-To: <20180602043241.9941-7-pclouds@gmail.com>

On Sat, Jun 2, 2018 at 12:32 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Show 12 quoted lines

> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> diff --git a/builtin/replace.c b/builtin/replace.c
> @@ -456,10 +456,10 @@ static int create_graft(int argc, const char **argv, int force, int gentle)
> -       if (remove_signature(&buf)) {
> -               warning(_("the original commit '%s' has a gpg signature."), old_ref);
> -               warning(_("the signature will be removed in the replacement commit!"));
> -       }
> +       if (remove_signature(&buf))
> +               warning(_("the original commit '%s' has a gpg signature.\n"
> +                         "The signature will be removed in the replacement commit!"),
> +                       old_ref);

It's kind of weird to drop capitalization of the first sentence but not the second. Also, you dropped trailing "!" in some other patches; do you want to do so here? Perhaps, instead:

    the original commit '%s' has a gpg signature;
    the signature will be removed in the replacement commit