From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 03 Jun 2018 18:27:57 GMT
Subject: Re: [PATCH 19/22] sequencer.c: mark more strings for translation
Message-ID: <CAPig+cQUC64j6RUZG3LWP+dm9HrvCBi+ayO0w5pmCkBU=vO_1A@mail.gmail.com>
In-Reply-To: <CACsJy8BXHDK8s-tSVkMG8sSu+DXwKxSkGqN+7ME8Lm9CjOx9GQ@mail.gmail.com>

On Sun, Jun 3, 2018 at 11:14 AM, Duy Nguyen <pclouds@gmail.com> wrote:
> On Sun, Jun 3, 2018 at 10:16 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> On Sat, Jun 2, 2018 at 12:32 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>>> -               fprintf(stderr, "Could not apply %s... %.*s\n",
>>> +               fprintf_ln(stderr, _("Could not apply %s... %.*s"),
>>
>> Did you want to downcase "Could" for consistency with other error
>> messages, or was this left as-is intentionally?
>
> I'm not sure. Others start with a prefix (like "error:",
> "warning:"....). This is a bit different and makes me hesitate.

Yep, I realized after hitting Send that this wasn't an error/warning
message so probably shouldn't be changed.