Re: [RFC/PATCH 2/8] update-index: add --test-untracked-cache

From: Christian Couder <christian.couder@gmail.com>
Date: Dec 7, 2015, 06:18 UTC
Message-ID: <CAP8UFD3qN-_OcdmuaGBAMBToQqf5c2pB+Dvdh3JPb9+S6m3vsQ@mail.gmail.com>
In-Reply-To: <CACsJy8ChATsTatRdz2wM23vfXy_8o1V5FEwMXo+PBqTBzZBBQA@mail.gmail.com>

On Wed, Dec 2, 2015 at 8:17 PM, Duy Nguyen <pclouds@gmail.com> wrote:

Show 19 quoted lines

> On Tue, Dec 1, 2015 at 9:31 PM, Christian Couder
> <christian.couder@gmail.com> wrote:
>> diff --git a/builtin/update-index.c b/builtin/update-index.c
>> index e568acc..b7b5108 100644
>> --- a/builtin/update-index.c
>> +++ b/builtin/update-index.c
>> @@ -996,8 +996,10 @@ int cmd_update_index(int argc, const char **argv, const char *prefix)
>>                         N_("enable or disable split index")),
>>                 OPT_BOOL(0, "untracked-cache", &untracked_cache,
>>                         N_("enable/disable untracked cache")),
>> +               OPT_SET_INT(0, "test-untracked-cache", &untracked_cache,
>> +                           N_("test if the filesystem supports untracked cache"), 2),
>>                 OPT_SET_INT(0, "force-untracked-cache", &untracked_cache,
>> -                           N_("enable untracked cache without testing the filesystem"), 2),
>> +                           N_("enable untracked cache without testing the filesystem"), 3),
>>                 OPT_END()
>>         };
>
> I think we got enough numbers to start using enum instead.

Ok, I will use an enum.