Re: [RFC/PATCH 1/8] update-index: add untracked cache notifications

From: Christian Couder <christian.couder@gmail.com>
Date: Dec 7, 2015, 09:08 UTC
Message-ID: <CAP8UFD0w9X+7TfPvW0mPxgU75HMR=1WWb6baJ2YrdNTDETJ6hQ@mail.gmail.com>
In-Reply-To: <CACsJy8BWEQNnpoXNBWSmmm-Ff7jJ9=+D6748TMXFyospU7jt1A@mail.gmail.com>

On Wed, Dec 2, 2015 at 8:16 PM, Duy Nguyen <pclouds@gmail.com> wrote:

Show 32 quoted lines

> On Tue, Dec 1, 2015 at 9:31 PM, Christian Couder
> <christian.couder@gmail.com> wrote:
>> Doing:
>>
>>   cd /tmp
>>   git --git-dir=/git/somewhere/else/.git update-index --untracked-cache
>>
>> doesn't work how one would expect. It hardcodes "/tmp" as the directory
>> that "works" into the index, so if you use the working tree, you'll
>> never use the untracked cache.
>>
>> With this patch "git update-index --untracked-cache" tells the user in
>> which directory tests are performed and in which working directory the
>> untracked cache is allowed.
>>
>> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
>> ---
>>  builtin/update-index.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/builtin/update-index.c b/builtin/update-index.c
>> index 7431938..e568acc 100644
>> --- a/builtin/update-index.c
>> +++ b/builtin/update-index.c
>> @@ -121,7 +121,7 @@ static int test_if_untracked_cache_is_supported(void)
>>         if (!mkdtemp(mtime_dir.buf))
>>                 die_errno("Could not make temporary directory");
>>
>> -       fprintf(stderr, _("Testing "));
>> +       fprintf(stderr, _("Testing mtime in '%s' "), xgetcwd());
>
> We probably should respect --verbose. I know I violated it in the first place.

The verbose help is:

    --verbose             report actions to standard output

so yeah, it is not respected first because the output is on by default, and second because the output is on stderr instead of stdout. Anyway it can be a separate patch or patch series to make it respect one or both of these points.

I am not very much interested in doing it myself as I think it's interesting to have the output by default especially if the above patch is applied. But if people agree that it would be a good thing, I will do it.