git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC/PATCH 1/8] update-index: add untracked cache notifications

From
Christian Couder <christian.couder@gmail.com>
Date
Dec 1, 2015, 20:31 UTC
Message-ID
<1449001899-18956-2-git-send-email-chriscool@tuxfamily.org>
In-Reply-To
<1449001899-18956-1-git-send-email-chriscool@tuxfamily.org>
Doing:
  cd /tmp
  git --git-dir=/git/somewhere/else/.git update-index --untracked-cache

doesn't work how one would expect. It hardcodes "/tmp" as the directory that "works" into the index, so if you use the working tree, you'll never use the untracked cache.

With this patch "git update-index --untracked-cache" tells the user in which directory tests are performed and in which working directory the untracked cache is allowed.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 builtin/update-index.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/builtin/update-index.c b/builtin/update-index.c
index 7431938..e568acc 100644
--- a/builtin/update-index.c
+++ b/builtin/update-index.c
@@ -121,7 +121,7 @@ static int test_if_untracked_cache_is_supported(void)
 	if (!mkdtemp(mtime_dir.buf))
 		die_errno("Could not make temporary directory");
 
-	fprintf(stderr, _("Testing "));
+	fprintf(stderr, _("Testing mtime in '%s' "), xgetcwd());
 	atexit(remove_test_directory);
 	xstat_mtime_dir(&st);
 	fill_stat_data(&base, &st);
@@ -1122,9 +1122,11 @@ int cmd_update_index(int argc, const char **argv, const char *prefix)
 		}
 		add_untracked_ident(the_index.untracked);
 		the_index.cache_changed |= UNTRACKED_CHANGED;
+		fprintf(stderr, _("Untracked cache enabled for '%s'\n"), get_git_work_tree());
 	} else if (!untracked_cache && the_index.untracked) {
 		the_index.untracked = NULL;
 		the_index.cache_changed |= UNTRACKED_CHANGED;
+		fprintf(stderr, _("Untracked disabled\n"));
 	}
 
 	if (active_cache_changed) {
-- 
2.6.3.391.g95a3a5c
Previous: Christian CouderNext: Duy Nguyen
Message 2 of 24 in “Untracked cache improvements”
  1. 0/8 Untracked cache improvementsChristian Couder, Dec 1, 2015
  2. 1/8 update-index: add untracked cache notificationsChristian Couder, Dec 1, 2015
  3. Duy NguyenDec 2, 2015
  4. Christian CouderDec 7, 2015
  5. Duy NguyenDec 7, 2015
  6. 2/8 update-index: add --test-untracked-cacheChristian Couder, Dec 1, 2015
  7. Duy NguyenDec 2, 2015
  8. Christian CouderDec 7, 2015
  9. 3/8 update-index: move 'uc' var declarationChristian Couder, Dec 1, 2015
  10. 4/8 dir: add add_untracked_cache()Christian Couder, Dec 1, 2015
  11. 5/8 dir: add remove_untracked_cache()Christian Couder, Dec 1, 2015
  12. 6/8 config: add core.untrackedCacheChristian Couder, Dec 1, 2015
  13. Torsten BögershausenDec 2, 2015
  14. Ævar Arnfjörð BjarmasonDec 2, 2015
  15. Torsten BögershausenDec 3, 2015
  16. Christian CouderDec 3, 2015
  17. Torsten BögershausenDec 4, 2015
  18. Christian CouderDec 4, 2015
  19. 7/8 update-index: prevent --untracked-cache from performing testsChristian Couder, Dec 1, 2015
  20. Duy NguyenDec 2, 2015
  21. Christian CouderDec 7, 2015
  22. 8/8 update-index: make core.untrackedCache a boolChristian Couder, Dec 1, 2015
  23. Torsten BögershausenDec 5, 2015
  24. Christian CouderDec 7, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.