Re: [RFC/PATCH 1/8] update-index: add untracked cache notifications
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Dec 7, 2015, 09:12 UTC
- Message-ID
- <CACsJy8Dd9qVGNOfn-g=Ys_KL=SqRVyAp4Jd67KM64GRvu8gsgQ@mail.gmail.com>
- In-Reply-To
- <CAP8UFD0w9X+7TfPvW0mPxgU75HMR=1WWb6baJ2YrdNTDETJ6hQ@mail.gmail.com>
On Mon, Dec 7, 2015 at 10:08 AM, Christian Couder <christian.couder@gmail.com> wrote:
Show 25 quoted lines
> On Wed, Dec 2, 2015 at 8:16 PM, Duy Nguyen <pclouds@gmail.com> wrote:
>>> --- a/builtin/update-index.c
>>> +++ b/builtin/update-index.c
>>> @@ -121,7 +121,7 @@ static int test_if_untracked_cache_is_supported(void)
>>> if (!mkdtemp(mtime_dir.buf))
>>> die_errno("Could not make temporary directory");
>>>
>>> - fprintf(stderr, _("Testing "));
>>> + fprintf(stderr, _("Testing mtime in '%s' "), xgetcwd());
>>
>> We probably should respect --verbose. I know I violated it in the first place.
>
> The verbose help is:
>
> --verbose report actions to standard output
>
> so yeah, it is not respected first because the output is on by
> default, and second because the output is on stderr instead of stdout.
> Anyway it can be a separate patch or patch series to make it respect
> one or both of these points.
>
> I am not very much interested in doing it myself as I think it's
> interesting to have the output by default especially if the above
> patch is applied. But if people agree that it would be a good thing, I
> will do it.Then we can leave it out. Not important (until people actually complain).
-- Duy