Re: [RFC/PATCH 1/8] update-index: add untracked cache notifications
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Dec 2, 2015, 19:16 UTC
- Message-ID
- <CACsJy8BWEQNnpoXNBWSmmm-Ff7jJ9=+D6748TMXFyospU7jt1A@mail.gmail.com>
- In-Reply-To
- <1449001899-18956-2-git-send-email-chriscool@tuxfamily.org>
On Tue, Dec 1, 2015 at 9:31 PM, Christian Couder <christian.couder@gmail.com> wrote:
Show 28 quoted lines
> Doing:
>
> cd /tmp
> git --git-dir=/git/somewhere/else/.git update-index --untracked-cache
>
> doesn't work how one would expect. It hardcodes "/tmp" as the directory
> that "works" into the index, so if you use the working tree, you'll
> never use the untracked cache.
>
> With this patch "git update-index --untracked-cache" tells the user in
> which directory tests are performed and in which working directory the
> untracked cache is allowed.
>
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
> builtin/update-index.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/builtin/update-index.c b/builtin/update-index.c
> index 7431938..e568acc 100644
> --- a/builtin/update-index.c
> +++ b/builtin/update-index.c
> @@ -121,7 +121,7 @@ static int test_if_untracked_cache_is_supported(void)
> if (!mkdtemp(mtime_dir.buf))
> die_errno("Could not make temporary directory");
>
> - fprintf(stderr, _("Testing "));
> + fprintf(stderr, _("Testing mtime in '%s' "), xgetcwd());We probably should respect --verbose. I know I violated it in the first place.
-- Duy