git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC/PATCH 2/8] update-index: add --test-untracked-cache

From
Christian Couder <christian.couder@gmail.com>
Date
Dec 1, 2015, 20:31 UTC
Message-ID
<1449001899-18956-3-git-send-email-chriscool@tuxfamily.org>
In-Reply-To
<1449001899-18956-1-git-send-email-chriscool@tuxfamily.org>

It is nice to just be able to test if untracked cache is supported without enabling it.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 Documentation/git-update-index.txt | 9 ++++++++-
 builtin/update-index.c             | 8 ++++++--
 2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt
index 3df9c26..0ff7396 100644
--- a/Documentation/git-update-index.txt
+++ b/Documentation/git-update-index.txt
@@ -17,7 +17,7 @@ SYNOPSIS
 	     [--[no-]assume-unchanged]
 	     [--[no-]skip-worktree]
 	     [--ignore-submodules]
-	     [--[no-|force-]untracked-cache]
+	     [--[no-|test-|force-]untracked-cache]
 	     [--really-refresh] [--unresolve] [--again | -g]
 	     [--info-only] [--index-info]
 	     [-z] [--stdin] [--index-version <n>]
@@ -179,6 +179,13 @@ may not support it yet.
 	system must change `st_mtime` field of a directory if files
 	are added or deleted in that directory.
 
+--test-untracked-cache::
+	Only perform tests on the working directory to make sure
+	untracked cache can be used. You have to manually enable
+	untracked cache using `--force-untracked-cache` (or
+	`--untracked-cache` but this will run the tests again)
+	afterwards if you really want to use it.
+
 --force-untracked-cache::
 	For safety, `--untracked-cache` performs tests on the working
 	directory to make sure untracked cache can be used. These
diff --git a/builtin/update-index.c b/builtin/update-index.c
index e568acc..b7b5108 100644
--- a/builtin/update-index.c
+++ b/builtin/update-index.c
@@ -996,8 +996,10 @@ int cmd_update_index(int argc, const char **argv, const char *prefix)
 			N_("enable or disable split index")),
 		OPT_BOOL(0, "untracked-cache", &untracked_cache,
 			N_("enable/disable untracked cache")),
+		OPT_SET_INT(0, "test-untracked-cache", &untracked_cache,
+			    N_("test if the filesystem supports untracked cache"), 2),
 		OPT_SET_INT(0, "force-untracked-cache", &untracked_cache,
-			    N_("enable untracked cache without testing the filesystem"), 2),
+			    N_("enable untracked cache without testing the filesystem"), 3),
 		OPT_END()
 	};
 
@@ -1107,10 +1109,12 @@ int cmd_update_index(int argc, const char **argv, const char *prefix)
 	if (untracked_cache > 0) {
 		struct untracked_cache *uc;
 
-		if (untracked_cache < 2) {
+		if (untracked_cache < 3) {
 			setup_work_tree();
 			if (!test_if_untracked_cache_is_supported())
 				return 1;
+			if (untracked_cache == 2)
+				return 0;
 		}
 		if (!the_index.untracked) {
 			uc = xcalloc(1, sizeof(*uc));
-- 
2.6.3.391.g95a3a5c
Previous: Duy NguyenNext: Duy Nguyen
Message 6 of 24 in “Untracked cache improvements”
  1. 0/8 Untracked cache improvementsChristian Couder, Dec 1, 2015
  2. 1/8 update-index: add untracked cache notificationsChristian Couder, Dec 1, 2015
  3. Duy NguyenDec 2, 2015
  4. Christian CouderDec 7, 2015
  5. Duy NguyenDec 7, 2015
  6. 2/8 update-index: add --test-untracked-cacheChristian Couder, Dec 1, 2015
  7. Duy NguyenDec 2, 2015
  8. Christian CouderDec 7, 2015
  9. 3/8 update-index: move 'uc' var declarationChristian Couder, Dec 1, 2015
  10. 4/8 dir: add add_untracked_cache()Christian Couder, Dec 1, 2015
  11. 5/8 dir: add remove_untracked_cache()Christian Couder, Dec 1, 2015
  12. 6/8 config: add core.untrackedCacheChristian Couder, Dec 1, 2015
  13. Torsten BögershausenDec 2, 2015
  14. Ævar Arnfjörð BjarmasonDec 2, 2015
  15. Torsten BögershausenDec 3, 2015
  16. Christian CouderDec 3, 2015
  17. Torsten BögershausenDec 4, 2015
  18. Christian CouderDec 4, 2015
  19. 7/8 update-index: prevent --untracked-cache from performing testsChristian Couder, Dec 1, 2015
  20. Duy NguyenDec 2, 2015
  21. Christian CouderDec 7, 2015
  22. 8/8 update-index: make core.untrackedCache a boolChristian Couder, Dec 1, 2015
  23. Torsten BögershausenDec 5, 2015
  24. Christian CouderDec 7, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.