Re: [PATCH v4 2/5] unpack-trees: add performance tracing

From: Thomas Adam <thomas@xteddy.org>
Date: Aug 12, 2018, 10:05 UTC
Message-ID: <CAOhcEPZphaKASyMAmZ5erdn-fygdVrvtPScTL_zZmAAgCYYKqQ@mail.gmail.com>
In-Reply-To: <20180812081551.27927-3-pclouds@gmail.com>

On Sun, 12 Aug 2018 at 09:19, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Hi,

> +       trace_performance_leave("cache_tree_update");

I would suggest trace_performance_leave() calls use __func__ instead. That way, there's no ambiguity if the function name ever changes.

Kindly, Thomas

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.