Re: [PATCH v4 2/5] unpack-trees: add performance tracing

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 13, 2018, 22:41 UTC
Message-ID: <xmqqk1ot3n4h.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180813192526.GC10013@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I can buy the argument that it's nice to have some form of profiling
> that works everywhere, even if it's lowest-common-denominator. I just
> wonder if we could be investing effort into tooling around existing
> solutions that will end up more powerful and flexible in the long run.

Another thing I noticed is that the codepaths we would find interesting to annotate with trace_performance_* stuff often overlaps with the "slog" thing. If the latter aims to eventually replace GIT_TRACE (and if not, I suspect there is not much point adding it in the first place), perhaps we can extend it to also cover the need of these trace_performance_* calls, so that we do not have to carry three different tracing mechanisms.