Re: [PATCH v4 2/5] unpack-trees: add performance tracing
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 13, 2018, 18:50 UTC
- Message-ID
- <xmqqin4e5ced.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CAOhcEPZphaKASyMAmZ5erdn-fygdVrvtPScTL_zZmAAgCYYKqQ@mail.gmail.com>
Thomas Adam <thomas@xteddy.org> writes:
Show 8 quoted lines
> On Sun, 12 Aug 2018 at 09:19, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>
> Hi,
>
>> + trace_performance_leave("cache_tree_update");
>
> I would suggest trace_performance_leave() calls use __func__ instead.
> That way, there's no ambiguity if the function name ever changes.Please don't, unless you are certain that everybody has __func__ in the first place.