Re: [PATCH v3 0/4] Speed up unpack_trees()

From: Ben Peart <peartben@gmail.com>
Date: Aug 8, 2018, 17:00 UTC
Message-ID: <a8be62e2-528b-72cc-56c7-55291af8dd66@gmail.com>
In-Reply-To: <xmqqr2jbnwy2.fsf@gitster-ct.c.googlers.com>

On 8/6/2018 2:59 PM, Junio C Hamano wrote:

Show 8 quoted lines

> Duy Nguyen <pclouds@gmail.com> writes:
> 
>> We require the unpacked entry from all input trees to be a tree
>> objects (the dirmask thing), so if one tree has 't' as a file,
> 
> Ah, OK, this is still part of that "all the trees match cache tree
> so we walk the index instead" optimization.  I forgot about that.
>

I ran this set of patches through the VFS For Git set of functional tests as well as our performance test suite (my earlier perf numbers were from manual testing). All the functional tests pass and the performance tests are looking _very_ promising.

Checkout times are impacted most and on average drop from 20.96 seconds to 11.63 seconds for a 45% savings.

Merge times drop from 19.44 seconds to 12.88 for a 34% savings.

Rebase times drop from 26.78 seconds to 20.72 for a 23% savings.

Overall, I'm looking forward to a good review of the patches and seeing them get merged as soon as they are ready.