From: Thomas Adam Date: Sun, 12 Aug 2018 10:05:37 GMT Subject: Re: [PATCH v4 2/5] unpack-trees: add performance tracing Message-ID: In-Reply-To: <20180812081551.27927-3-pclouds@gmail.com> On Sun, 12 Aug 2018 at 09:19, Nguyễn Thái Ngọc Duy wrote: Hi, > + trace_performance_leave("cache_tree_update"); I would suggest trace_performance_leave() calls use __func__ instead. That way, there's no ambiguity if the function name ever changes. Kindly, Thomas