Re: [PATCH GSoC v4 3/9] fetch-object-info: pass arguments directly instead of a struct
Pablo Sabater <pabloosabaterr@gmail.com> writes:
Show 6 quoted lines
> struct object_info_args groups three pointers that already live in the
> transport and are given to fetch_object_info().
> Grouping them into a struct reduces the number of parameters, but it
> suggests that the three belong together, when they are unrelated and end
> up being accessed as args->* independently.
>
This reads much better and explains why we make the change.
> Drop the struct and pass those parameters directly to
> fetch_object_info() and send_object_info_request(). This should have no
> change in behavior.
[snip]
The changes too look in order.
Karthik Nayak <karthik.188@gmail.com>