From: Karthik Nayak <karthik.188@gmail.com>
Date: Thu, 06 Aug 2026 11:21:06 GMT
Subject: Re: [PATCH GSoC v4 3/9] fetch-object-info: pass arguments directly instead of a struct
Message-ID: <CAOLa=ZT_Zv82cWdhK6rJiAQm05WjdPwfG0p7nLO9pZ-hiX4g3Q@mail.gmail.com>
In-Reply-To: <20260804-objecttype-support-v4-3-31511b0231be@gmail.com>

Pablo Sabater <pabloosabaterr@gmail.com> writes:

> struct object_info_args groups three pointers that already live in the
> transport and are given to fetch_object_info().
> Grouping them into a struct reduces the number of parameters, but it
> suggests that the three belong together, when they are unrelated and end
> up being accessed as args->* independently.
>

This reads much better and explains why we make the change.

> Drop the struct and pass those parameters directly to
> fetch_object_info() and send_object_info_request(). This should have no
> change in behavior.

[snip]

The changes too look in order.