Re: [PATCH GSoC v3 3/8] fetch-object-info: pass arguments directly instead of a struct
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 3, 2026, 18:23 UTC
- Message-ID
- <xmqq33wvyseb.fsf@gitster.g>
- In-Reply-To
- <20260803-objecttype-support-v3-3-7176fecf7950@gmail.com>
Pablo Sabater <pabloosabaterr@gmail.com> writes:
Show 19 quoted lines
> struct object_info_args groups three pointers that already live in the > transport and are given to fetch_object_info(). > Grouping them into a struct reduces the number of parameters, but it > suggests that fetch_object_info() uses all three of them. > > Drop the struct and pass those parameters directly to > fetch_object_info() and send_object_info_request(). This should have no > change in behavior. > > Helped-by: Jeff King <peff@peff.net> > Helped-by: Junio C Hamano <gitster@pobox.com> > Mentored-by: Karthik Nayak <karthik.188@gmail.com> > Mentored-by: Chandra Pratap <chandrapratap3519@gmail.com> > Signed-off-by: Pablo Sabater <pabloosabaterr@gmail.com> > --- > fetch-object-info.c | 53 +++++++++++++++++++++++++++++++---------------------- > fetch-object-info.h | 17 ++++++++--------- > transport.c | 11 +++++------ > 3 files changed, 44 insertions(+), 37 deletions(-)
This has lots of changes but quite straight-forward. We lose the intermediate wrapper "object_info_args" and the uses of the members of that wrapper structure are updated with direct reference to a variable.