Re: [PATCH GSoC v6 06/10] transport: drop remote object-info fields from transport struct

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 8, 2026, 16:21 UTC
Message-ID: <xmqqmruwbn21.fsf@gitster.g>
In-Reply-To: <20260808-objecttype-support-v6-6-e5cdaf27a49c@gmail.com>

Pablo Sabater <pabloosabaterr@gmail.com> writes:

Show 6 quoted lines

> Rather than take these as function parameters, we take only the
> transport object, and expect the caller to have placed the other two
> into special fields in the transport struct. But this doesn't make much
> sense. The set of oids and results are really only valid for one
> request. There is no reason the transport would need to hang on to them
> outside of the single function call.

Thanks for injecting some sanity into the mix.

With this fixed, are we happy with the entire series by now?

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.