Re: [PATCH GSoC v6 06/10] transport: drop remote object-info fields from transport struct

From: Karthik Nayak <karthik.188@gmail.com>
Date: Aug 11, 2026, 07:43 UTC
Message-ID: <CAOLa=ZTrf_WHiRHTjBGAus+YbRsUkbR3dzsW=fgCK0jit6fYzQ@mail.gmail.com>
In-Reply-To: <CA+J6zkR5ZkUc8c=xiXgKiAYmbgcoyGfwpgm6aaG0Gog8OVmOjw@mail.gmail.com>

Chandra Pratap <chandrapratap3519@gmail.com> writes:

Show 20 quoted lines

> On Sat, 8 Aug 2026 at 21:51, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Pablo Sabater <pabloosabaterr@gmail.com> writes:
>>
>> > Rather than take these as function parameters, we take only the
>> > transport object, and expect the caller to have placed the other two
>> > into special fields in the transport struct. But this doesn't make much
>> > sense. The set of oids and results are really only valid for one
>> > request. There is no reason the transport would need to hang on to them
>> > outside of the single function call.
>>
>> Thanks for injecting some sanity into the mix.
>>
>> With this fixed, are we happy with the entire series by now?
>
> Just went through the series and everything looks good to me, but I've had
> the same opinion for the last couple of iterations as well.
>
> Thanks,
> Chandra.

Same. This version looks good to me too :)