Re: [PATCH v3 0/4] enhance string-list API to fix sign compare warnings

From: Karthik Nayak <karthik.188@gmail.com>
Date: Oct 8, 2025, 08:11 UTC
Message-ID: <CAOLa=ZQzfzRkzK5qkg+rJWqZ4mE9fn06tx9njGzGt4YNi3kDwg@mail.gmail.com>
In-Reply-To: <xmqq1pnfof71.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 18 quoted lines

> shejialuo <shejialuo@gmail.com> writes:
>
>> Hi All:
>>
>> This is a small PATCH to enhance string-list API
>> "string_list_find_insert_index" which has introduced sign compare
>> warnings.
>>
>> ---
>>
>> Changes since v2:
>>
>> 1. Enhance [PATCH v2 2/4] commit message to express the motivation is
>>    avoid overflow.
>> 2. Add comments for `string_list_find_insert_index` function.
>
> Thanks.  I didn't see anything glaringly wrong in this round.
>

Same, the range-diff looks good to me!

Thanks

> Shall we mark the topic for 'next' now?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.