Re: [PATCH v2 2/4] string-list: replace negative index encoding with "exact_match" parameter

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 24, 2025, 13:20 UTC
Message-ID: <xmqqwm5om1gy.fsf@gitster.g>
In-Reply-To: <20250924053601.GC1173044@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I agree that size_t is much more than one needs for counting most
> things. But the problem is that "int" is much too small, if you are
> worried about malicious input causing integer overflows that could cause
> memory access errors.

Well, a malicious input can cause overflow/wraparound size_t while parsing, so I do not think that is really an argument.

The code need to be protected against such overflows either way.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.