Re: [PATCH v3 0/4] enhance string-list API to fix sign compare warnings

From: Collin Funk <collin.funk1@gmail.com>
Date: Oct 8, 2025, 01:52 UTC
Message-ID: <87frbudusr.fsf@gmail.com>
In-Reply-To: <xmqq1pnfof71.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Thanks.  I didn't see anything glaringly wrong in this round.
>
> Shall we mark the topic for 'next' now?

These look good to me if you want to add:

Reviewed-by: Collin Funk <collin.funk1@gmail.com>

I wrote a bit about the signed vs. unsigned integer for object/indexes in another mail. Because of my opinion on that, I usually just ignore these warnings. But my impression is that my opinion is in the minority regarding that. :)

Collin

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.