From: Karthik Nayak Date: Wed, 08 Oct 2025 08:11:05 GMT Subject: Re: [PATCH v3 0/4] enhance string-list API to fix sign compare warnings Message-ID: In-Reply-To: Junio C Hamano writes: > shejialuo writes: > >> Hi All: >> >> This is a small PATCH to enhance string-list API >> "string_list_find_insert_index" which has introduced sign compare >> warnings. >> >> --- >> >> Changes since v2: >> >> 1. Enhance [PATCH v2 2/4] commit message to express the motivation is >> avoid overflow. >> 2. Add comments for `string_list_find_insert_index` function. > > Thanks. I didn't see anything glaringly wrong in this round. > Same, the range-diff looks good to me! Thanks > Shall we mark the topic for 'next' now?