Re: [PATCH 06/10] reftable/generic: move generic iterator code into iterator interface
- From
karthik nayak <karthik.188@gmail.com>
- Date
- Aug 13, 2024, 10:04 UTC
- Message-ID
- <CAOLa=ZQ15h8bFRGGhzJUPNwkCrRmc2Y26n-0x+L_V_06xWgd7g@mail.gmail.com>
- In-Reply-To
- <14924604cebe20ac30d291399b0200016fa8b4e3.1723528765.git.ps@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
[snip]
Show 7 quoted lines
> +
> +void reftable_iterator_destroy(struct reftable_iterator *it)
> +{
> + if (!it->ops) {
> + return;
> + }
>I know this commit is to move, but I couldn't help noticing that we should remove the curly braces here.
Seems like the CI caught it too [1].
Show 5 quoted lines
> + it->ops->close(it->iter_arg); > + it->ops = NULL; > + FREE_AND_NULL(it->iter_arg); > +} > +
[snip]
[1]: https://gitlab.com/gitlab-org/git/-/jobs/7563308943