git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 01/10] reftable/merged: expose functions to initialize iterators

From
Justin Tobler <jltobler@gmail.com>
Date
Aug 19, 2024, 16:55 UTC
Message-ID
<wb5nteglnm4bfu5pe3xqtdatsv4byyah4py6m2imp6wsh2xspo@bft2kvapv6vh>
In-Reply-To
<404d64effde3bee424e338d858ed507ff83dff20.1723528765.git.ps@pks.im>
On 24/08/13 08:24AM, Patrick Steinhardt wrote:
Show 10 quoted lines
> We do not expose any functions via our public headers that would allow a
> caller to initialize a reftable iterator from a merged table. Instead,
> they are expected to go via the generic `reftable_table` interface,
> which is somewhat roundabout.
> 
> Implement two new functions to initialize iterators for ref and log
> records to plug this gap.
> 
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
[snip]
Show 15 quoted lines
> diff --git a/reftable/reftable-merged.h b/reftable/reftable-merged.h
> index 14d5fc9f05..4deb0ad22e 100644
> --- a/reftable/reftable-merged.h
> +++ b/reftable/reftable-merged.h
> @@ -36,6 +36,14 @@ int reftable_new_merged_table(struct reftable_merged_table **dest,
>  			      struct reftable_table *stack, size_t n,
>  			      uint32_t hash_id);
>  
> +/* Initialize a merged table iterator for reading refs. */
> +void reftable_merged_table_init_ref_iterator(struct reftable_merged_table *mt,
> +					     struct reftable_iterator *it);
> +
> +/* Initialize a merged table iterator for reading logs. */
> +void reftable_merged_table_init_log_iterator(struct reftable_merged_table *mt,
> +					     struct reftable_iterator *it);

I might have missed it, but I do not see `reftable_merged_table_init_log_iterator()` used anywhere in the later patches. Does this need to be added? Or are we just adding it because we want a companion function to the ref iterator to be more consistent?

-Justin
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 5 of 25 in “reftable: drop generic `reftable_table` interface”
  1. 00/10 reftable: drop generic `reftable_table` interfacePatrick Steinhardt, Aug 13, 2024
  2. 01/10 reftable/merged: expose functions to initialize iteratorsPatrick Steinhardt, Aug 13, 2024
  3. karthik nayakAug 13, 2024
  4. Patrick SteinhardtAug 14, 2024
  5. Justin ToblerAug 19, 2024
  6. Patrick SteinhardtAug 20, 2024
  7. 02/10 reftable/merged: rename `reftable_new_merged_table()`Patrick Steinhardt, Aug 13, 2024
  8. 03/10 reftable/merged: stop using generic tables in the merged tablePatrick Steinhardt, Aug 13, 2024
  9. karthik nayakAug 13, 2024
  10. Justin ToblerAug 19, 2024
  11. 04/10 reftable/stack: open-code reading refsPatrick Steinhardt, Aug 13, 2024
  12. 05/10 reftable/iter: drop double-checking logicPatrick Steinhardt, Aug 13, 2024
  13. Eric SunshineAug 13, 2024
  14. 06/10 reftable/generic: move generic iterator code into iterator interfacePatrick Steinhardt, Aug 13, 2024
  15. karthik nayakAug 13, 2024
  16. Patrick SteinhardtAug 14, 2024
  17. Junio C HamanoAug 14, 2024
  18. karthik nayakAug 15, 2024
  19. 07/10 reftable/dump: drop unused `compact_stack()`Patrick Steinhardt, Aug 13, 2024
  20. 08/10 reftable/dump: drop unused printing functionalityPatrick Steinhardt, Aug 13, 2024
  21. karthik nayakAug 13, 2024
  22. Patrick SteinhardtAug 14, 2024
  23. 09/10 reftable/dump: move code into "t/helper/test-reftable.c"Patrick Steinhardt, Aug 13, 2024
  24. 10/10 reftable/generic: drop interfacePatrick Steinhardt, Aug 13, 2024
  25. karthik nayakAug 13, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.