Re: [PATCH 05/10] reftable/iter: drop double-checking logic
On Tue, Aug 13, 2024 at 2:24 AM Patrick Steinhardt <ps@pks.im> wrote:
> The filtering ref iterator can be used to only yield refs which are not
> in a specific skip list. This iterator has an option to double-check the
> results it returns, which causes us to seek tho reference we are about
Show 13 quoted lines
> to yield via a separate table such that we detect whether the reference
> that the first iterator has yielded actually exists.
>
> The value of this is somewhat dubious, and I cannot think of any usecase
> where this functionality should be required. Furthermore, this option is
> never set in our codebase, which means that it is essentially untested.
> And last but not least, the `struct reftable_table` that is used to
> implement it is about to go away.
>
> So while we could refactor the code to not use a `reftable_table`, it
> very much feels like a wasted effort. Let's just drop this code.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
Eric Sunshine <sunshine@sunshineco.com>