From: karthik nayak Date: Tue, 13 Aug 2024 10:04:30 GMT Subject: Re: [PATCH 06/10] reftable/generic: move generic iterator code into iterator interface Message-ID: In-Reply-To: <14924604cebe20ac30d291399b0200016fa8b4e3.1723528765.git.ps@pks.im> Patrick Steinhardt writes: [snip] > + > +void reftable_iterator_destroy(struct reftable_iterator *it) > +{ > + if (!it->ops) { > + return; > + } > I know this commit is to move, but I couldn't help noticing that we should remove the curly braces here. Seems like the CI caught it too [1]. > + it->ops->close(it->iter_arg); > + it->ops = NULL; > + FREE_AND_NULL(it->iter_arg); > +} > + [snip] [1]: https://gitlab.com/gitlab-org/git/-/jobs/7563308943