git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 00/10] reftable: drop generic `reftable_table` interface

From
karthik nayak <karthik.188@gmail.com>
Date
Aug 13, 2024, 10:17 UTC
Message-ID
<CAOLa=ZREWViEAxBbVTGfTtb3ZwxO8NiVc6GkQEbgyKBEheFH6g@mail.gmail.com>
In-Reply-To
<cover.1723528765.git.ps@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 19 quoted lines
> Hi,
>
> this patch series performs some simplification of the reftable library
> by dropping the generic `reftable_table` interface. The intent of this
> interface is to abstract away whether the underlying table is either a
> single reftable, or a merged reftable. Arguably though, it is not needed
> anymore starting with my recent refactorings [1] that made the reftable
> iterator itself seekable, as that now provides such a generic interface
> already.
>
> So this patch series rips out the `reftable_table` interface, both to
> remove unused clutter, but more importantly to make the reftable library
> easier to understand overall. There is also a tiny performance gain of
> 1-3% by requiring one less vtable function call. But while that speedup
> is consistent, I didn't include any benchmarks as it is rather close to
> noise and not the primary motivation of this patch series.
>
> Patrick
>

This is a very welcome change, the indirection was a cause for confusion before and this clears it up.

My only concern is the loss of dumping reftables for debug purposes in patch 8, I suggest we keep them until we have alternatives. Apart from that everything looks great.

Thanks!
Previous: Patrick Steinhardt
Message 25 of 25 in “reftable: drop generic `reftable_table` interface”
  1. 00/10 reftable: drop generic `reftable_table` interfacePatrick Steinhardt, Aug 13, 2024
  2. 01/10 reftable/merged: expose functions to initialize iteratorsPatrick Steinhardt, Aug 13, 2024
  3. karthik nayakAug 13, 2024
  4. Patrick SteinhardtAug 14, 2024
  5. Justin ToblerAug 19, 2024
  6. Patrick SteinhardtAug 20, 2024
  7. 02/10 reftable/merged: rename `reftable_new_merged_table()`Patrick Steinhardt, Aug 13, 2024
  8. 03/10 reftable/merged: stop using generic tables in the merged tablePatrick Steinhardt, Aug 13, 2024
  9. karthik nayakAug 13, 2024
  10. Justin ToblerAug 19, 2024
  11. 04/10 reftable/stack: open-code reading refsPatrick Steinhardt, Aug 13, 2024
  12. 05/10 reftable/iter: drop double-checking logicPatrick Steinhardt, Aug 13, 2024
  13. Eric SunshineAug 13, 2024
  14. 06/10 reftable/generic: move generic iterator code into iterator interfacePatrick Steinhardt, Aug 13, 2024
  15. karthik nayakAug 13, 2024
  16. Patrick SteinhardtAug 14, 2024
  17. Junio C HamanoAug 14, 2024
  18. karthik nayakAug 15, 2024
  19. 07/10 reftable/dump: drop unused `compact_stack()`Patrick Steinhardt, Aug 13, 2024
  20. 08/10 reftable/dump: drop unused printing functionalityPatrick Steinhardt, Aug 13, 2024
  21. karthik nayakAug 13, 2024
  22. Patrick SteinhardtAug 14, 2024
  23. 09/10 reftable/dump: move code into "t/helper/test-reftable.c"Patrick Steinhardt, Aug 13, 2024
  24. 10/10 reftable/generic: drop interfacePatrick Steinhardt, Aug 13, 2024
  25. karthik nayakAug 13, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.