Re: [PATCH 06/10] reftable/generic: move generic iterator code into iterator interface

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 14, 2024, 12:56 UTC
Message-ID: <ZryplD3NsINRMxY1@tanuki>
In-Reply-To: <CAOLa=ZQ15h8bFRGGhzJUPNwkCrRmc2Y26n-0x+L_V_06xWgd7g@mail.gmail.com>

On Tue, Aug 13, 2024 at 06:04:30AM -0400, karthik nayak wrote:

Show 16 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> [snip]
> 
> > +
> > +void reftable_iterator_destroy(struct reftable_iterator *it)
> > +{
> > +	if (!it->ops) {
> > +		return;
> > +	}
> >
> 
> I know this commit is to move, but I couldn't help noticing that we
> should remove the curly braces here.
> 
> Seems like the CI caught it too [1].

Fair enough, let's remove them.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.