Re: [PATCH 0/4] rename "sha1-foo" files

From: Martin Ågren <martin.agren@gmail.com>
Date: Dec 30, 2020, 08:04 UTC
Message-ID: <CAN0heSo88-o0fgBM-_Sx6JXN4RxVX-fW84Kt-VgttytM=Qad-A@mail.gmail.com>
In-Reply-To: <X+wAahx00v9VqzV5@camp.crustytoothpaste.net>

On Wed, 30 Dec 2020 at 05:22, brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 12 quoted lines

>
> On 2020-12-29 at 23:52:56, Martin Ågren wrote:
> > We have some source files with filenames such as sha1-lookup.c and
> > sha1-name.c containing a few variable names, comments and the like
> > referencing "sha1". But they are able to handle SHA-256 as well. Here's
> > my attempt at removing "sha1" from the contents and names of these
> > files.
>
> I agree that this series looks pretty good, and thanks for sending it.
> This series ended up being a lot smaller than I expected given the work
> on the transition, which is a nice surprise and also means it's less
> likely to conflict with other topics in flight.

It's a lot smaller than I expected, too -- I looked into one file and figured it would be littered with "sha" instances, but was pleasantly surprised so I continued. Certainly, the only reason this series is smaller than expected is because of all the work that has already been put into the transition. Thank you!

Martin