Re: [PATCH 1/4] object-name.c: rename from sha1-name.c

From: Derrick Stolee <stolee@gmail.com>
Date: Dec 30, 2020, 01:19 UTC
Message-ID: <7cc9ac55-1e9a-05ed-fde6-a422804ed3b9@gmail.com>
In-Reply-To: <aac3a3c3e202f790f11089e2c8f814bea9943831.1609282997.git.martin.agren@gmail.com>

On 12/29/2020 6:52 PM, Martin Ågren wrote:

Show 10 quoted lines

> Generalize the last remnants of "sha" and "sha1" in this file and rename
> it to reflect that we're not just able to handle SHA-1 these days.
> 
> Signed-off-by: Martin Ågren <martin.agren@gmail.com>
> ---
>  list-objects-filter.c        |  2 +-
>  sha1-name.c => object-name.c | 14 +++++++-------
>  Makefile                     |  2 +-
>  3 files changed, 9 insertions(+), 9 deletions(-)
>  rename sha1-name.c => object-name.c (99%)

I was tempted to recommend making the content changes to sha1-name.c in a preperatory patch then doing a patch that preforms an exact rename (along with edits to Makefile and list-objects-filter.c).

However, I talked myself out of it while writing this
response. Having an exact rename won't materially change
how "git log --follow" or "git blame" behave.
 
Thanks,
-Stolee