Re: [PATCH v5 00/15] fast-export and remote-testgit improvements

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 21, 2012, 09:46 UTC
Message-ID: <CAMP44s3h5+KS3ixoLkJeiS+n_neBV-Dyj=Cww0ZrU6UKsNxphQ@mail.gmail.com>
In-Reply-To: <1352642392-28387-1-git-send-email-felipe.contreras@gmail.com>

On Sun, Nov 11, 2012 at 2:59 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Since these are having some problems getting in, let me point out which I think are important, and which not.

> Felipe Contreras (15):
>   fast-export: avoid importing blob marks

This fixes a bug, but it's probably not hitting many people.

>   remote-testgit: fix direction of marks
>   remote-helpers: fix failure message

I don't care.

>   Rename git-remote-testgit to git-remote-testpy
>   Add new simplified git-remote-testgit

These I think are good.

>   remote-testgit: get rid of non-local functionality
>   remote-testgit: remove irrelevant test
>   remote-testgit: cleanup tests

Just cleanups.

>   remote-testgit: exercise more features

I think it's good to catch more issues, but I don't care much.

>   remote-testgit: report success after an import
>   remote-testgit: make clear the 'done' feature

These are good, but I could drop them.

>   fast-export: trivial cleanup
>   fast-export: fix comparison in tests

Obvious and correct, but I don't care.

>   fast-export: make sure updated refs get updated

This is the important one. It fixes real issues quite visible on remote helpers.

>   fast-export: don't handle uninteresting refs

This is nice, but can be dropped.

I don't see what are the chances of any of them getting merged, but at least 'fast-export: make sure updated refs get updated' should definitely go in. Please advice at which level I should drop the patches, because at this point it doesn't look like any of them are going in.

Cheers.

-- 
Felipe Contreras