Re: [PATCH v5 01/15] fast-export: avoid importing blob marks
- From
Jeff King <peff@peff.net>
- Date
- Nov 11, 2012, 16:38 UTC
- Message-ID
- <20121111163827.GA11408@sigill.intra.peff.net>
- In-Reply-To
- <509FD425.5030702@web.de>
On Sun, Nov 11, 2012 at 05:36:53PM +0100, Torsten Bögershausen wrote:
Show 13 quoted lines
> On 11.11.12 14:59, Felipe Contreras wrote: > > test_expect_success 'test biridectionality' ' > > + echo -n > marks-cur && > > + echo -n > marks-new && > Unless I messed up the patch: > > Minor issue: still a typo "biridectionality" > Major issue: "echo -n" is still not portable. > > Could we simply use > > touch marks-cur && > touch marks-new
Yes, "echo -n" is definitely not portable. Our preferred way of creating an empty file is just ">file".
-Peff