Re: [PATCH v5 15/15] fast-export: don't handle uninteresting refs

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 24, 2012, 03:12 UTC
Message-ID: <CAMP44s38qTcSk4PLMkjgyyNq3OJn9QhTV7MuzseB8jPM3GnmeA@mail.gmail.com>
In-Reply-To: <1352642392-28387-16-git-send-email-felipe.contreras@gmail.com>

On Sun, Nov 11, 2012 at 2:59 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 13 quoted lines

> --- a/builtin/fast-export.c
> +++ b/builtin/fast-export.c
> @@ -529,7 +529,9 @@ static void get_tags_and_duplicates(struct object_array *pending,
>                  * sure it gets properly upddated eventually.
>                  */
>                 if (commit->util || commit->object.flags & SHOWN)
> -                       string_list_append(extra_refs, full_name)->util = commit;
> +                       if (!(commit->object.flags & UNINTERESTING))
> +                               string_list_append(extra_refs, full_name)->util = commit;
> +
>                 if (!commit->util)
>                         commit->util = full_name;
>         }

There is one case where this can cause problems. I'm about to send another patch series where I fix transport-helper to behave more properly, and in doing so it sends things such as '^old-master master new', and if new points to master, there's a problem. This means the user would have to do 'git push new', instead of 'git push --all'. The transport-helper could do the reset itself, but that would require parsing the marks. A simpler solution for this is proposed in the next patch series.

Cheers.

-- 
Felipe Contreras